One should forgive as in restore anyone who genuinely repents. But we cant do that with an unrepentant killer for instance.
One should forgive as in give up bitterness etc everyone, whether they repented or not. One can do that towards even an unrepentant killer. That releases us from them, inside of us.